feat: Manifest File Reader #1500
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2025
scovich
reviewed
Nov 20, 2025
Comment on lines
+135
to
+138
| batch_result.and_then(|batch| { | ||
| self.sidecar_visitor.visit_rows_of(batch.actions())?; | ||
| Ok(batch) | ||
| }) |
Collaborator
There was a problem hiding this comment.
Suggested change
| batch_result.and_then(|batch| { | |
| self.sidecar_visitor.visit_rows_of(batch.actions())?; | |
| Ok(batch) | |
| }) | |
| let batch = batch_result?; | |
| self.sidecar_visitor.visit_rows_of(batch.actions())?; | |
| Ok(batch) |
Comment on lines
+81
to
+84
| ext => { | ||
| return Err(Error::generic(format!( | ||
| "Unsupported checkpoint extension: {}", | ||
| ext |
Collaborator
There was a problem hiding this comment.
Suggested change
| ext => { | |
| return Err(Error::generic(format!( | |
| "Unsupported checkpoint extension: {}", | |
| ext | |
| _ => { | |
| return Err(Error::generic(format!( | |
| "Unsupported checkpoint extension: {extension}", |
Comment on lines
+71
to
+80
| "json" => { | ||
| engine | ||
| .json_handler() | ||
| .read_json_files(&files, MANIFEST_READ_SCHMEA.clone(), None)? | ||
| } | ||
| "parquet" => engine.parquet_handler().read_parquet_files( | ||
| &files, | ||
| MANIFEST_READ_SCHMEA.clone(), | ||
| None, | ||
| )?, |
Collaborator
There was a problem hiding this comment.
aside: I'm a bit surprised fmt treated these so differently?
(but it's the same number of lines of code either way, so meh)
| .path() | ||
| .rsplit('.') | ||
| .next() | ||
| .unwrap_or(""); |
Collaborator
There was a problem hiding this comment.
Technically, we don't need to unwrap... just match as:
let actions = match extension {
Some("json") => { ... }
Some("parquet") => { ... }| #[allow(unused)] | ||
| pub(crate) enum AfterManifest { | ||
| /// Has sidecars → return sidecar files | ||
| Sidecars { sidecars: Vec<FileMeta> }, |
Collaborator
There was a problem hiding this comment.
Seems like a reasonable place for a tuple enum variant, since the field name is redundant?
Suggested change
| Sidecars { sidecars: Vec<FileMeta> }, | |
| Sidecars(Vec<FileMeta>), |
| require!( | ||
| self.is_complete, | ||
| Error::generic(format!( | ||
| "Finalized called on ManifestReader for file {:?}", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "Finalized called on ManifestReader for file {:?}", | |
| "Cannot finalize in-progress ManifestReader for file {:?}", |
| )) | ||
| ); | ||
|
|
||
| let sidecars: Vec<_> = self |
Collaborator
There was a problem hiding this comment.
Type annotation shouldn't be necessary here because AfterManifest::Sidecars forces it
Suggested change
| let sidecars: Vec<_> = self | |
| let sidecars = self |
OussamaSaoudi
force-pushed
the
stack/dlr_manifest
branch
from
92737a4 to
698da9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
How was this change tested?